Skip to content

deps: bump MSRV to 1.91.1 #6048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
marxin wants to merge 3 commits into
base: main
Choose a base branch
from
Open

deps: bump MSRV to 1.91.1 #6048

marxin wants to merge 3 commits into from
+14 −14

Conversation

@marxin
Copy link
Contributor

@marxin marxin commented Jan 13, 2026

Even though, the next Rust release will be chopped in one week from now, I would prefer doing the bump a bit earlier as it's going to be the version used for 7.0 final release.

Copilot AI review requested due to automatic review settings January 13, 2026 09:18
Copilot AI reviewed Jan 13, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@marxin marxin enabled auto-merge (squash) January 13, 2026 12:28
theduke
theduke reviewed Jan 14, 2026
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have become a bit aggressive with bumping versions.

The previous policy was current - 3, I believe, so that would currently be 1.89.

I know we did several bumps because of dependencies, which are necessary, but I don't think we should bump unless forced to do so by a dependency, or if there are new features we really want.

What's the motivation for bumping now?

Also bumping to a minor version seems confusing to me, I haven't seen anyone do that.
Users will upgrade to patch versions anyway.

@marxin
Copy link
Contributor Author

marxin commented Jan 15, 2026

The previous policy was current - 3, I believe, so that would currently be 1.89.

No, we agreed on for latest 3 releases: https://github.com/wasmerio/wasmer/blob/main/docs/BUILD.md#installing-rustup
That means, currently, the oldest supported is 1.90.

What's the motivation for bumping now?

Expecting the 7.0 release in the upcoming week (or two), the MSRV would be 1.91 (will be released in 1 week from now) at that time. And so I would like to bump it a bit earlier.

Also bumping to a minor version seems confusing to me, I haven't seen anyone do that.
Users will upgrade to patch versions anyway.

Fair point, let me change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theduke theduke theduke left review comments

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marxin @theduke